aws lambda - relayer observer #1483
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eikix
reviewed
Oct 9, 2024
kakarot_scripts/aws_lambda/relayers_observer/lambda_function.py
Outdated
Show resolved
Hide resolved
Eikix
reviewed
Oct 9, 2024
|
Can you add AWS CDK Python probably it is the best idea |
kakarot_scripts/aws_lambda/relayers_observer/lambda_function.py
Outdated
Show resolved
Hide resolved
kakarot_scripts/aws_lambda/relayers_observer/lambda_function.py
Outdated
Show resolved
Hide resolved
kakarot_scripts/aws_lambda/relayers_observer/lambda_function.py
Outdated
Show resolved
Hide resolved
kakarot_scripts/aws_lambda/relayers_observer/lambda_function.py
Outdated
Show resolved
Hide resolved
Eikix
reviewed
Oct 14, 2024
...lambda/relayers_observer/relayers_observer_service/relayers_observer_lambda/requirements.txt
Outdated
Show resolved
Hide resolved
Comment on lines
1
to
5
| # trunk-ignore-all(trivy/DS002) | ||
| # trunk-ignore-all(trivy/DS026) | ||
| # trunk-ignore-all(checkov/CKV_DOCKER_2) | ||
| # trunk-ignore-all(checkov/CKV_DOCKER_3) | ||
| # trunk-ignore-all(hadolint/DL3033) |
There was a problem hiding this comment.
why do we need to exclude them all?
There was a problem hiding this comment.
in my opinion should be excluded, these are the the lint issues:
- Ensure that HEALTHCHECK instructions have been added to container images
- Ensure that a user for the container has been created
- Specify version with `yum install -y <package>-<version>`
- Pin versions in pip. Instead of `pip install <package>` use `pip install <package>==<version>`
- Specify at least 1 USER command in Dockerfile with non-root user as argument
...da/relayers_observer/relayers_observer_service/relayers_observer_lambda/relayers_observer.py
Outdated
Show resolved
Hide resolved
...da/relayers_observer/relayers_observer_service/relayers_observer_lambda/relayers_observer.py
Outdated
Show resolved
Hide resolved
...da/relayers_observer/relayers_observer_service/relayers_observer_lambda/relayers_observer.py
Outdated
Show resolved
Hide resolved
...da/relayers_observer/relayers_observer_service/relayers_observer_lambda/relayers_observer.py
Outdated
Show resolved
Hide resolved
...da/relayers_observer/relayers_observer_service/relayers_observer_lambda/relayers_observer.py
Outdated
Show resolved
Hide resolved
...da/relayers_observer/relayers_observer_service/relayers_observer_lambda/relayers_observer.py
Outdated
Show resolved
Hide resolved
eugypalu
force-pushed
the
relayers-observer
branch
from
54d7138
to
7f926bb
Compare
|
What is the status of this @eugypalu |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1527
Pull request type
Please check the type of change your PR introduces:
What is the new behavior?
This Lambda automates the process of maintaining relayer balances, ensuring they always have sufficient funds to operate
Balance monitoring: Periodically checks the ETH balance of the main relayer account and individual relayers.
Automatic funding: If a relayer's balance falls below a predefined threshold, the Lambda attempts to fund it automatically with a fixed amount of ETH.
Slack notifications: Sends alerts to Slack channel #relayers-observer when:
Uses AWS Secrets Manager to securely retrieve the private keys necessary for transactions.
Manual replenishment of the main account: avoid automating the withdraw call to the coinbase address to replenish the main relayer account. This decision was taken to prevent the need for an automatic call by the contract owner within the Lambda, thus maintaining greater control over significant fund replenishment operations.
This change is